Re: [GIT PULL] gpio updates for v6.18-rc1

[Linus Torvalds]

On Mon, 29 Sept 2025 at 02:41, Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> Here's the PR containing the GPIO updates for this merge window. There are
> two new drivers and support for more models in existing ones.

This appears to not have been build-tested AT ALL.

> - allow building gpio-stmpe as a module

This causes build errors:

  ERROR: modpost: missing MODULE_LICENSE() in drivers/mfd/stmpe-i2c.o
  ERROR: modpost: missing MODULE_LICENSE() in drivers/mfd/stmpe-spi.o

because while the main core stmpe.c driver got an added

  MODULE_LICENSE("GPL");

when it was turned into a modular build, the SPI and i2c modules did not.

It's trivial to fix, but I should not be in the situation where I have
to fix it, and I should not be getting pull requests that don't even
build under trivial configurations.

How the hell did this happen? Where was the basic build testing?

                            Linus