Re: [PATCH RESEND] x86/boot: Add option to append to the cmdline
From: Dave Hansen
Date: Wed Oct 01 2025 - 20:13:46 EST
On 10/1/25 16:04, Brian Mak wrote:
> To solve this limitation, we add CONFIG_CMDLINE_EXTEND, which is already
> available on several other architectures, to make the built-in command
> line append to the bootloader-provided command line.
I'd really rather not have another copy-and-paste of another
architecture's Kconfig bits into x86.
At the _very_ least, we'd get a boolean ARCH_HAS_CMDLIND_EXTEND which
would then expose an arch-independent CMDLINE_EXTEND option. Literally
duplicating Kconfig options just isn't scalable.
I also cringe every time I see code like this get added to arch/x86 that
really doesn't have anything to do with x86 and really only gets dumped
in to arch/ because there's never been a proper refactoring of all the
copy-and-pasted code.
In the end, refactoring Kconfig is dirt simple. Refactoring
builtin_cmdline[] into arch-independent code would be a lot harder.