Re: [PATCH 1/8] dt-bindings: panel: Add Samsung S6E3FC2X01 DDIC with panel

[Rob Herring]

On Thu, Sep 25, 2025 at 11:12:47AM +0200, David Heidelberg wrote:
> Basic description for S6E3FC2X01 DDIC with attached panel AMS641RW.
> 
> Signed-off-by: David Heidelberg <david@xxxxxxx>
> ---
>  .../bindings/display/panel/samsung,s6e3fc2x01.yaml | 77 ++++++++++++++++++++++
>  MAINTAINERS                                        |  5 ++
>  2 files changed, 82 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3fc2x01.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e3fc2x01.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..489b6b52effe1e627ff5ef5891729c175ad71685
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e3fc2x01.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/samsung,s6e3fc2x01.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung S6E3FC2X01 AMOLED DDIC
> +
> +description: The S6E3FC2X01 is display driver IC with connected panel.
> +
> +maintainers:
> +  - David Heidelberg <david@xxxxxxx>
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: samsung,s6e3fc2x01-ams641rw

On second thought, this doesn't even tell me the resolution of the 
panel. The existing compatible you remove at least did that.