RE: [PATCH V3 2/2] tty: serial: imx: Add missing wakeup event reporting

[Sherry Sun]

> -----Original Message-----
> From: Jiri Slaby <jirislaby@xxxxxxxxxx>
> Sent: Monday, September 29, 2025 1:58 PM
> To: Frank Li <frank.li@xxxxxxx>; Sherry Sun <sherry.sun@xxxxxxx>
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; shawnguo@xxxxxxxxxx;
> s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx;
> Shenwei Wang <shenwei.wang@xxxxxxx>; Peng Fan <peng.fan@xxxxxxx>;
> linux-serial@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> imx@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH V3 2/2] tty: serial: imx: Add missing wakeup event
> reporting
> 
> On 25. 09. 25, 17:49, Frank Li wrote:
> >> @@ -2732,10 +2734,14 @@ static void imx_uart_enable_wakeup(struct
> imx_port *sport, bool on)
> >>   			ucr1 |= UCR1_RTSDEN;
> >>   		} else {
> >>   			ucr1 &= ~UCR1_RTSDEN;
> >> +			wake_active |= !!(usr1 & USR1_RTSD);
> >
> > I think you miss understand my means. suppose bool type only support
> > ||, &&, ==, !=, !
> >
> > 	wake_active = wake_active || (usr1 & USR1_RTSD);
> 
> +1 to this. Much easier to understand (for me at least).

Hi Frank and Jiri, thanks for the suggestions, now I got your point, will fix it in next version.

Best Regards
Sherry