Re: [PATCH v2 08/20] verification/dot2c: Remove superfluous enum assignment and add last comma

From: Nam Cao
Date: Thu Oct 02 2025 - 05:41:15 EST


Gabriele Monaco <gmonaco@xxxxxxxxxx> writes:

> The header files generated by dot2c currently create enums for states
> and events assigning the first element to 0. This is superfluous as it
> happens automatically if no value is specified.
> Also it doesn't add a comma to the last enum elements, which slightly
> complicates the diff if states or events are added.
>
> Remove the assignment to 0 and add a comma to last elements, this
> simplifies the logic for the code generator.
>
> Signed-off-by: Gabriele Monaco <gmonaco@xxxxxxxxxx>

There are some minor changes which are not mentioned, but not a big deal:

Reviewed-by: Nam Cao <namcao@xxxxxxxxxxxxx>