Re: [PATCH v2 11/20] verification/rvgen: Allow spaces in and events strings

From: Nam Cao
Date: Thu Oct 02 2025 - 07:03:18 EST


Gabriele Monaco <gmonaco@xxxxxxxxxx> writes:

> Currently the automata parser assumes event strings don't have any
> space, this stands true for event names, but can be a wrong assumption
> if we want to store other information in the event strings (e.g.
> constraints for hybrid automata).
>
> Adapt the parser logic to allow spaces in the event strings.

I probably misunderstand something, but isn't the description
misleading? After reading this description, I expect the patch to ignore
spaces or something similar. But from my understanding, the script only
allowed a single event, and this patch allows conditions as well.

Shouldn't this be squashed to the next patch?

Nam