Re: [PATCH 1/1] tools build: Don't assume libtracefs-devel is always available

[Tomas Glozar]

čt 2. 10. 2025 v 15:05 odesílatel Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> napsal:
>
> perf doesn't use libtracefs and so it doesn't make sense to assume it is
> always available when building test-all.bin, defeating the feature check
> speedup it provides.
>
> The other tools/build/ users such as rtla, rv, etc call $(feature_check
> libtracefs) to check its availability instead of using the test-all.bin
> mechanism, stopping the build and asking for libtracefs-devel to be
> installed.
>
> Noticed after applying Ian Roger's removal unused libtracefs
> configuration in tools/perf/.
>
> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Cc: Gabriele Monaco <gmonaco@xxxxxxxxxx>
> Cc: Ian Rogers <irogers@xxxxxxxxxx>
> Cc: James Clark <james.clark@xxxxxxxxxx>
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Tomas Glozar <tglozar@xxxxxxxxxx>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

Acked-by: Tomas Glozar <tglozar@xxxxxxxxxx>

Perhaps it would also make sense to clarify in a comment that
test-all.c is to speed up perf build rather than rv, rtla etc. (which
don't use most of the dependencies listed there)?

Tomas