Re: [PATCH 1/1 v2] tools build: Don't assume libtracefs-devel is always available

[Ian Rogers]

On Thu, Oct 2, 2025 at 8:47 AM Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
>
> perf doesn't use libtracefs and so it doesn't make sense to assume it is
> always available when building test-all.bin, defeating the feature check
> speedup it provides.
>
> The other tools/build/ users such as rtla, rv, etc call $(feature_check
> libtracefs) to check its availability instead of using the test-all.bin
> mechanism, stopping the build and asking for libtracefs-devel to be
> installed.
>
> Remove it from FEATURE_TESTS_BASIC to not have it as available, as noted
> by Ian Rogers during review.
>
> Acked-by: Tomas Glozar <tglozar@xxxxxxxxxx>
> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Cc: Gabriele Monaco <gmonaco@xxxxxxxxxx>
> Cc: Ian Rogers <irogers@xxxxxxxxxx>
> Cc: James Clark <james.clark@xxxxxxxxxx>
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks!
Ian

> ---
>  tools/build/Makefile.feature   | 1 -
>  tools/build/feature/test-all.c | 5 -----
>  2 files changed, 6 deletions(-)
>
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index 9c1a69d26f5121fd..531f8fc4f7df9943 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -83,7 +83,6 @@ FEATURE_TESTS_BASIC :=                  \
>          libpython                       \
>          libslang                        \
>          libtraceevent                   \
> -        libtracefs                      \
>          libcpupower                     \
>          pthread-attr-setaffinity-np     \
>          pthread-barrier                \
> diff --git a/tools/build/feature/test-all.c b/tools/build/feature/test-all.c
> index e1847db6f8e63750..2df593593b6ec15e 100644
> --- a/tools/build/feature/test-all.c
> +++ b/tools/build/feature/test-all.c
> @@ -150,10 +150,6 @@
>  # include "test-libtraceevent.c"
>  #undef main
>
> -#define main main_test_libtracefs
> -# include "test-libtracefs.c"
> -#undef main
> -
>  int main(int argc, char *argv[])
>  {
>         main_test_libpython();
> @@ -187,7 +183,6 @@ int main(int argc, char *argv[])
>         main_test_reallocarray();
>         main_test_libzstd();
>         main_test_libtraceevent();
> -       main_test_libtracefs();
>
>         return 0;
>  }
> --
> 2.49.0
>