Re: [PATCH v2] iio: accel: bma400: Refactor generic interrupt configuration
From: Akshay Jindal
Date: Thu Oct 02 2025 - 15:00:36 EST
On Sun, Sep 28, 2025 at 3:14 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> Hi Akshay,
> I appreciate I replied probably after you sent this, but the request
> to split the renames out as a precursor that Nuno made is still valid.
> They add noise to the patch and make it harder to review.
>
> In general I'd like to see this broken into several steps/patches.
>
> I've mentioned some things to break out inline but it'll be something like
> * Field renames.
> * Documentation and explicit field definitions for initial values.
> * activity_event_en() rename
> * Change in how register addresses are obtained.
> * White space changes if you want to make them.
> Ordering is largely up to you to figure out.
>
> So I think at least 4 separate patches doing much smaller things.
> That should make it much easier to see what is going on in each.
>
> Various specific comments inline.
Hi Jonathan,
Thank you for your valuable feedback on the patch.
Have floated a v3. As you suggested above, it is a patch series consisting
of 5 logically separable changes. Also addressed your comments mentioned
inline.
Thanks,
Akshay.