Re: [PATCH] net: fsl_pq_mdio: Fix device node reference leak in fsl_pq_mdio_probe

[Simon Horman]

On Fri, Oct 03, 2025 at 08:33:24AM +0100, Simon Horman wrote:
> On Thu, Oct 02, 2025 at 08:46:17PM +0300, Erick Karanja wrote:
> > Add missing of_node_put call to release device node tbi obtained
> > via for_each_child_of_node.
> > 
> > Fixes: afae5ad78b342 ("net/fsl_pq_mdio: streamline probing of MDIO nodes")
> 
> nit: no blank line here
> 
> Slightly more importantly, although the code you are changing
> was added by the cited commit, I think that the bug existed before then.
> I wonder if the fixes tag should be.
> 
> Fixes: daa26ea63c6f ("Merge branch 'octeontx2-fix-bitmap-leaks-in-pf-and-vf'")

Sorry the above is obviously bogus.
I should have said:

Fixes: 1577ecef7666 ("netdev: Merge UCC and gianfar MDIO bus drivers")

> 
> > 
> > Signed-off-by: Erick Karanja <karanja99erick@xxxxxxxxx>
> 
> One minor comment on process: as a fix for networking code, most likely this
> should be targeted at the net tree. And that should be denoted in the
> subject like this:
> 
> Subject: [PATCH net] ...
> 
> And if you do post an updated version, which is probably not strictly
> necessary, please be sure to observe the 24h rule.
> 
> See: https://docs.kernel.org/process/maintainer-netdev.html
> 
> The code changes themselves look good to me. Thanks.
> 
> Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
> 
> ...
>