Re: [PATCH v16 0/9] Add PWM support for IPQ chipsets

[Kathiravan Thirumoorthy]

On 10/3/2025 3:00 PM, George Moussalem wrote:
> Hi Kathiravan,
>
> On 10/3/25 13:04, Kathiravan Thirumoorthy wrote:
> > On 10/1/2025 7:34 PM, George Moussalem via B4 Relay wrote:
> > > Add PWM driver and binding support for IPQ chipsets.
> > > Also, add nodes to add support for pwm in ipq6018, ipq5018, ipq5332, and
> > > ipq9574.
> > >
> > > I've picked up work based on Devi's last submission (v15) which dates
> > > back to 05 October 2023 as below SoCs are still active.
> > >
> > > V16:
> > >
> > >     Removed reg description in bindings as the offset is not relative to
> > >     the TCSR region anymore since simple-mfd support was dropped and PWM
> > >     nodes defined as their own nodes, not child nodes. Updated the example
> > >     too.
> > >
> > >     Dropped patch to add simple-mfd support to the qcom,tcsr bindings
> > George, thanks for taking up this series.
> >
> > Can you elaborate on why the qcom,tcsr binding change is dropped and
> > made the PWM as an independent node? IIUC, it should be child of TCSR
> > node. In V15, I see the qcom,tcsr binding is applied and *dropped only*
> > due to dependencies / lack of information on the "pwm-cells" property.
> Please see below patch where it was decided to drop simple-mfd as TCSR
> is configuration only and any child devices should be defined outside of it:
> https://lore.kernel.org/all/20220909091056.128949-1-krzysztof.kozlowski@xxxxxxxxxx/


Hmm... Sorry I missed to check this one. Thanks for pointing it out.


> > Thanks,
> >
> > Kathiravan T.
> Best regards,
> George