Re: [PATCH] gpio: of: make it possible to reference gpios probed in acpi in device tree

From: Krzysztof Kozlowski

Date: Fri Oct 03 2025 - 06:58:19 EST


On Fri, 3 Oct 2025 at 17:51, Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> On Fri, Oct 3, 2025 at 10:40 AM Markus Probst <markus.probst@xxxxxxxxx> wrote:
> >
> > On Fri, 2025-10-03 at 10:03 +0200, Bartosz Golaszewski wrote:
> > > On Thu, Oct 2, 2025 at 11:58 PM Markus Probst
> > > <markus.probst@xxxxxxxxx> wrote:
> > > >
> > > > sometimes it is necessary to use both acpi and device tree to
> > > > declare
> > >
> > > This is a rather controversial change so "sometimes" is not
> > > convincing
> > > me. I would like to see a user of this added in upstream to consider
> > > it.
> > >
> > > > devices. Not every gpio device driver which has an acpi_match_table
> > > > has
> > > > an of_match table (e.g. amd-pinctrl). Furthermore gpio is an device
> > > > which
> > >
> > > What is the use-case here because I'm unable to wrap my head around
> > > it? Referencing devices described in ACPI from DT? How would the
> > > associated DT source look like?
> > In my specific usecase for the Synology DS923+, there are gpios for
> > powering the usb vbus on (powered down by default), also for powering
> > on sata disks. An example for a regulator defined in DT using a gpio in
> > ACPI (in this case controlling the power of on of the usb ports):
> >
> > gpio: gpio-controller@fed81500 {
> > acpi-path = "\\_SB_.GPIO";
> > #gpio-cells = <2>;
> > };
> >
> > vbus1_regulator: fixedregulator@0 {
> > compatible = "regulator-fixed";
> > regulator-name = "vbus1_regulator";
> > regulator-min-microvolt = <5000000>;
> > regulator-max-microvolt = <5000000>;
> > gpio = <&gpio 0x2a 0x01>;
> > };
> >
> > - Markus Probst
> > >
>
> Krzysztof: Could you please look at this and chime in? Does this make any sense?
>


In a week (Gmail on mobile absolutely ducks), after I'll dig out from
the emails. Feel free to ping again, in case I forget.