Re: [PATCH] kdb: delete unexecuted if-block in kdb_get_kbd_char()

From: Doug Anderson

Date: Fri Oct 03 2025 - 12:39:57 EST


Hi,

On Fri, Oct 3, 2025 at 8:13 AM Matvey Kovalev <matvey.kovalev@xxxxxxxxx> wrote:
>
> Bits of scancode are dropped except 7 low-order ones.
> So, scancode can't be equal 0xe0.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Matvey Kovalev <matvey.kovalev@xxxxxxxxx>
> ---
> kernel/debug/kdb/kdb_keyboard.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/debug/kdb/kdb_keyboard.c b/kernel/debug/kdb/kdb_keyboard.c
> index 3a74604fdb8a7..386d30e530b78 100644
> --- a/kernel/debug/kdb/kdb_keyboard.c
> +++ b/kernel/debug/kdb/kdb_keyboard.c
> @@ -145,9 +145,6 @@ int kdb_get_kbd_char(void)
> return CTRL('F');
> }
>
> - if (scancode == 0xe0)
> - return -1;
> -

The same patch has already been sent and was landed:

https://lore.kernel.org/all/20250507104337.201695-1-colin.i.king@xxxxxxxxx/