Re: [PATCH] hfs: fix potential use after free in hfs_correct_next_unused_CNID()

[Viacheslav Dubeyko]

On Fri, 2025-10-03 at 12:30 +0300, Dan Carpenter wrote:
> This code calls hfs_bnode_put(node) which drops the refcount and then
> dreferences "node" on the next line.  It's only safe to use "node"
> when we're holding a reference so flip these two lines around.
> 
> Fixes: a06ec283e125 ("hfs: add logic of correcting a next unused CNID")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
>  fs/hfs/catalog.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/hfs/catalog.c b/fs/hfs/catalog.c
> index caebabb6642f..b80ba40e3877 100644
> --- a/fs/hfs/catalog.c
> +++ b/fs/hfs/catalog.c
> @@ -322,9 +322,9 @@ int hfs_correct_next_unused_CNID(struct super_block *sb, u32 cnid)
>  			}
>  		}
>  
> +		node_id = node->prev;
>  		hfs_bnode_put(node);
>  
> -		node_id = node->prev;
>  	} while (node_id >= leaf_head);
>  
>  	return -ENOENT;

Yeah, makes sense. Good catch. :) I missed this. Thanks a lot for the fix.

Reviewed-by: Viacheslav Dubeyko <slava@xxxxxxxxxxx>

Thanks,
Slava.