Re: [PATCH v11 31/31] fs/resctrl: Some kerneldoc updates
From: Reinette Chatre
Date: Fri Oct 03 2025 - 20:27:00 EST
Hi Tony,
On 9/25/25 1:03 PM, Tony Luck wrote:
> resctrl event monitoring on Sub-NUMA Cluster (SNC) systems sums the
> counts for events across all nodes sharing an L3 cache.
>
> Update the kerneldoc for rmid_read::sum and the do_sum argument to
> mon_get_kn_priv() to say these are only used on the RDT_RESOURCE_L3
> resource.
This is clear from the patch. Why is this needed as part of
telemetry event enabling? Perhaps this can be combined with the
unrelated SNC warnings found in "x86/resctrl: Handle domain creation/deletion
for RDT_RESOURCE_PERF_PKG" to be a patch dedicated to addressing SNC
topics related to telemetry events?
>
> Add Return: value description for l3_mon_domain_mbm_alloc(),
> resctrl_l3_mon_resource_init(), and domain_setup_l3_mon_state()
Appreciate the cleanups but please have series start with cleanups instead of end.
>
> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
> ---
Reinette