Re: [PATCH RFC 3/6] ASoC: soc: qcom: sc8280xp: add support for I2S clocks

[Neil Armstrong]

On 10/7/25 03:35, Alexey Klimov wrote:
> On Mon Oct 6, 2025 at 7:37 PM BST, Neil Armstrong wrote:
> > Add support for getting the I2S clocks used for the MI2S
> > interfaces, and enable/disable the clocks on the PCM
> > startup and shutdown card callbacks.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   sound/soc/qcom/sc8280xp.c | 104 +++++++++++++++++++++++++++++++++++++++++++++-
> >   1 file changed, 103 insertions(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
> > index 78e327bc2f07767b1032f09af7f45b947e7eb67a..ad4ee5c6fab8994f18de572842f3dab6f4f5397e 100644
> > --- a/sound/soc/qcom/sc8280xp.c
> > +++ b/sound/soc/qcom/sc8280xp.c
> > @@ -4,6 +4,8 @@
> >   #include <dt-bindings/sound/qcom,q6afe.h>
> >   #include <linux/module.h>
> >   #include <linux/platform_device.h>
> > +#include <linux/clk.h>
> > +#include <linux/of_clk.h>
>
> ^^

I'll fix that

> [..]
>
> >   static const struct snd_soc_ops sc8280xp_be_ops = {
> > -	.startup = qcom_snd_sdw_startup,
> > +	.startup = sc8280xp_snd_startup,
> >   	.shutdown = sc8280xp_snd_shutdown,
> >   	.hw_params = sc8280xp_snd_hw_params,
> >   	.hw_free = sc8280xp_snd_hw_free,
> > @@ -162,6 +222,44 @@ static void sc8280xp_add_be_ops(struct snd_soc_card *card)
> >   	}
> >   }
> >   
> > +static const char * const i2s_bus_names[I2S_MAX_CLKS] = {
> > +	"primary",
> > +	"secondary",
> > +	"tertiary",
> > +	"quaternary",
> > +	"quinary",
> > +};
> > +
> > +static int sc8280xp_get_i2c_clocks(struct platform_device *pdev,
> > +				   struct sc8280xp_snd_data *data)
> > +{
>
> Could you please confirm that this should be _i2c_ clocks?

Damn, typo, it should obviously be i2s

Neil

> [..]
>
> Best regards,
> Alexey