Re: [PATCH v2] kbuild: uapi: Strip comments before size type check

From: Geert Uytterhoeven

Date: Mon Oct 06 2025 - 09:21:07 EST


Hi Andreas,

On Mon, 6 Oct 2025 at 14:40, Andreas Schwab <schwab@xxxxxxxxxxxxxx> wrote:
> On Okt 06 2025, Geert Uytterhoeven wrote:
> > --- a/usr/include/headers_check.pl
> > +++ b/usr/include/headers_check.pl
> > @@ -155,6 +155,8 @@ sub check_sizetypes
> > if (my $included = ($line =~ /^\s*#\s*include\s+[<"](\S+)[>"]/)[0]) {
> > check_include_typesh($included);
> > }
> > + # strip comments (single-line only)
> > + $line =~ s@\/\*.*?\*\/@@;
>
> I don't think you need to quote the forward slashes in the regexp.

Thanks, you are right!

So far for not just following my instinct, but looking for similar functionality
in other scripts like scripts/kernel-doc.pl...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds