Re: [PATCH v5 08/12] gpio: add QIXIS FPGA GPIO controller

[Linus Walleij]

Hi Ioana,

thanks for your patch!

On Mon, Sep 22, 2025 at 4:24 PM Ioana Ciornei <ioana.ciornei@xxxxxxx> wrote:

> Add support for the GPIO controller found on some QIXIS FPGAs in
> Layerscape boards such as LX2160ARDB and LS1046AQDS. This driver is
> using gpio-regmap.
>
> A GPIO controller has a maximum of 8 lines (all found in the same
> register). Even within the same controller, the GPIO lines' direction is
> fixed, which mean that both input and output lines are found in the same
> register. This is why the driver also passed to gpio-regmap the newly
> added .fixed_direction_output bitmap to represent the true direction of
> the lines.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>
> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
(...)
> +++ b/drivers/gpio/Kconfig
> @@ -1986,6 +1986,15 @@ config GPIO_LATCH
>           Say yes here to enable a driver for GPIO multiplexers based on latches
>           connected to other GPIOs.
>
> +config GPIO_QIXIS_FPGA
> +       tristate "NXP QIXIS FPGA GPIO support"
> +       depends on MFD_SIMPLE_MFD_I2C || COMPILE_TEST
> +       select GPIO_REGMAP
> +       help
> +         This enables support for the GPIOs found in the QIXIS FPGA which is
> +         integrated on some NXP Layerscape boards such as LX2160ARDB and
> +         LS1046AQDS.
> +
>  config GPIO_MOCKUP
>         tristate "GPIO Testing Driver (DEPRECATED)"
>         select IRQ_SIM

Why is this menu entry among the virtual GPIO drivers?
Move it under the MFD menu where it should be, please.

With this fixed:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij