Re: [PATCH net-next v02 4/6] hinic3: Add mac filter ops

[Markus Elfring]

…> +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_filter.c
> @@ -0,0 +1,413 @@
…> +static int hinic3_mac_filter_sync(struct net_device *netdev,
> +				  struct list_head *mac_filter_list, bool uc)
> +{
…
> +		hinic3_cleanup_filter_list(&tmp_add_list);> +		hinic3_mac_filter_sync_hw(netdev, &tmp_del_list, &tmp_add_list);
> +
> +		/* need to enter promiscuous/allmulti mode */
> +		err = -ENOMEM;
> +		goto err_out;
> +	}
> +
> +	return add_count;
> +
> +err_out:
> +	return err;
> +}

Is there a need to move any resource cleanup actions behind a more appropriate label?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.17#n532


Regards,
Markus