Re: [PATCH v2] PCI: xilinx-xdma: Enable INTx interrupts

[Stefan Roese]

On 10/23/25 08:35, Musham, Sai Krishna wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> > -----Original Message-----
> > From: Stefan Roese <stefan.roese@xxxxxxxxxxx>
> > Sent: Wednesday, October 22, 2025 7:08 PM
> > To: Musham, Sai Krishna <sai.krishna.musham@xxxxxxx>; mani@xxxxxxxxxx;
> > Havalige, Thippeswamy <thippeswamy.havalige@xxxxxxx>
> > Cc: Bjorn Helgaas <helgaas@xxxxxxxxxx>; Bandi, Ravi Kumar
> > <ravib@xxxxxxxxxx>; lpieralisi@xxxxxxxxxx; bhelgaas@xxxxxxxxxx; linux-
> > pci@xxxxxxxxxxxxxxx; kwilczynski@xxxxxxxxxx; robh@xxxxxxxxxx; Simek, Michal
> > <michal.simek@xxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx; Sean Anderson
> > <sean.anderson@xxxxxxxxx>; Yeleswarapu, Nagaradhesh
> > <nagaradhesh.yeleswarapu@xxxxxxx>
> > Subject: Re: [PATCH v2] PCI: xilinx-xdma: Enable INTx interrupts
> >
> > Caution: This message originated from an External Source. Use proper caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > On 10/22/25 14:48, Musham, Sai Krishna wrote:
> > > [AMD Official Use Only - AMD Internal Distribution Only]
> >
> > <snip>
> >
> > > > > We even don’t need ravi patch, as we have tested this at our end it
> > > > > works fine by just updating interrupt-map Property. We need to now
> > > > > understand the
> > > > difference in design.
> > > >
> > > > Ok, please let us know with your findings. In the meantime, I'll keep
> > > > Ravi's patch in tree, as it seems to be required on his setup.
> > >
> > > We tested on Linux version 6.12.40 without applying either Stefan's or Ravi's
> > patches.
> > > Instead, we applied only the following interrupt-map property change
> > > (entries 0,1,2,3) and verified that legacy interrupts are working correctly.
> > >
> > > interrupt-map = <0 0 0 1 &pcie_intc_0 0>,
> > > <0 0 0 2 &pcie_intc_0 1>,
> > > <0 0 0 3 &pcie_intc_0 2>,
> > > <0 0 0 4 &pcie_intc_0 3>;
> > >
> > > 38:       1143          0  pl_dma:RC-Event  16 Level     80000000.axi-pcie
> > > 39:       1143          0  pl_dma:INTx   0 Level     nvme0q0, nvme0q1
> >
> > Okay. Same here. I don't need Ravi's patch for the INTx bit enabling.
> >
> > I understand that you want us to change the interrupt map in the auto- generated
> > device-tree from Vivado. Which is IMHO a bit "suboptimal".
> >
> > I would prefer to have a solution which works out-of-the-box, w/o the need to
> > manually change DT properties. Is it planned to change / fix this interrupt map in
> > pl.dtsi generated with a newer version of Vivado?
>
> Yes Stefan, this will be fixed in the newer versions and the auto-generated
> device tree will include the correct interrupt-map property entries.

Understood. And thanks the update on this.

@Bjorn & Mani, this patch can be dropped then.

Thanks,
Stefan