Re: [RFC PATCH v2] page_alloc: allow migration of smaller hugepages during contig_alloc.
From: Gregory Price
Date: Wed Oct 22 2025 - 10:53:48 EST
On Tue, Oct 21, 2025 at 06:40:57PM -0700, SeongJae Park wrote:
> On Mon, 20 Oct 2025 17:08:16 -0400 Gregory Price <gourry@xxxxxxxxxx> wrote:
> > +
> > + /* Don't consider moving same size/larger pages */
> > + page = compound_head(page);
> > + order = compound_order(page);
> > + if ((order >= MAX_PAGE_ORDER) ||
> > + (nr_pages < (1 << order)))
> > + return false;
>
> Shouldn't the comparison of 'nr_pages' against '1 << order' use '<=' instead of
> '<', to match the commit description?
>
Good catch, got lost in the shuffle. Thank you!
~Gregory