Re: [PATCH v5] memory: tegra210: Support interconnect framework

[Aaron Kling]

On Mon, Oct 27, 2025 at 5:52 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 22/10/2025 05:10, Aaron Kling via B4 Relay wrote:
> > From: Aaron Kling <webgeek1234@xxxxxxxxx>
> >
> > This makes mc and emc interconnect providers and allows for dynamic
> > memory clock scaling.
> >
> > Signed-off-by: Aaron Kling <webgeek1234@xxxxxxxxx>
> > ---
> > Changes in v5:
> > - Split series
> > - Link to v4: https://lore.kernel.org/r/20250923-t210-actmon-v4-0-442d1eb6377c@xxxxxxxxx
> >
>
>
> Tried to apply... and see you did not run checkpatch.
>
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.

I ran b4 prep --check, which runs checkpatch and that passes. And none
of the kernel ci bots have complained. Normal checkpatch also passes.
If I run strict, I get a warning like the following:

#340: FILE: drivers/memory/tegra/tegra210-emc-core.c:2226:
+       if (!err) {
[...]
+       } else if (err != -ENODEV)
[...]

The code flow should be correct here. Is this what you are referring
to or are you getting an error/warning I'm not seeing?

Aaron