Re: [PATCH v3 2/4] clk: qcom: ecpricc-qdu100: Add mem_enable_mask to the clock memory branch
From: Taniya Das
Date: Thu Oct 30 2025 - 02:24:44 EST
On 10/24/2025 2:09 PM, Konrad Dybcio wrote:
> On 10/24/25 6:24 AM, Taniya Das wrote:
>> Add the newly introduced 'mem_enable_mask' to the memory control branch
>> clocks of ECPRI clock controller to align to the new mem_ops handling.
>>
>> Signed-off-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
>> ---
>
> This probably fixes some ugly issue, could you please mention what
> the impact/problem is?
>
Konrad, this isn’t an issue. Previously, the ECPRI clock controller’s
mem_ops clocks used the mem_enable_ack_mask bit directly for both
setting and polling. However, this approach didn’t apply to newer
mem_ops clocks.
Based on the feedback from v2, I’ve refactored the mem_ops code to
handle these cases more cleanly, which required updating the ECPRI
clocks as well.
--
Thanks,
Taniya Das