Re: [PATCH RESEND v2 2/3] power: supply: rt9756: Add Richtek RT9756 smart cap divider charger

[ChiYuan Huang]

On Fri, Sep 19, 2025 at 04:27:50PM +0800, ChiYuan Huang wrote:
> On Fri, Sep 19, 2025 at 01:43:02AM +0200, Sebastian Reichel wrote:
> Hi, Sebastian:
> > Hi,
> > 
> > On Thu, Aug 14, 2025 at 03:31:07PM +0800, cy_huang@xxxxxxxxxxx wrote:
> > > From: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
> > > 
> > > Add support for RT9756 smart cap divider charger.
> > > 
> > > The RT9759 is a high efficiency and high charge current charger. The
> > > maximum charge current is up to 8A. It integrates a dual-phase charge
> > > pump core with ADC monitoring.
> > > 
> > > Signed-off-by: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
> > > ---
> > 
> > Sorry for the delay. This looks mostly good, but I really don't like
> > the custom properties for the battery voltage and current. Instead
> > of handling via custom properties, register a second power_supply
> > device with POWER_SUPPLY_TYPE_BATTERY and use the normal 
> > POWER_SUPPLY_PROP_VOLTAGE_NOW and POWER_SUPPLY_PROP_CURRENT_NOW
> > properties. Having custom properties for the watchdog and the
> > operating mode is fine with me, as these two things are quite
> > specific to the RT9756 chips.
> > 
> > While you are at it, you can also add this constant property for
> > the battery device:
> > 
> > POWER_SUPPLY_PROP_TECHNOLOGY = POWER_SUPPLY_TECHNOLOGY_LION
> > 
> > Also the charger's power_supply_config should set the
> > .supplied_to, listing the battery device, so that the kernel
> > is aware of the link between those two devices.
> > 
> Essentianly, these two attributes are only used for battery monitoring
> from charger side perspective.
> 
> As you know, RT9756 is a charger, not fuelgauge. To register a second
> power supply seems weird. If what you cares is the keyword 'battery',
> I can change it to 'vout'. What do you think?

Since there's no reply for this discussion, I already followed your suggestion
for the next revision.

Thx.
> 
> Regards,
> ChiYuan.
> > Greetings,
> > 
> > -- Sebastian