Re: [PATCH v3 1/2] dt-bindings: firmware: svc: Add IOMMU support for Agilex5
From: Krzysztof Kozlowski
Date: Tue Nov 04 2025 - 04:54:32 EST
On Tue, Nov 04, 2025 at 07:39:27AM +0800, Khairul Anuar Romli wrote:
> In Agilex5, the TBU (Translation Buffer Unit) can now operate in non-secure
> mode, enabling Linux to utilize it through the IOMMU framework. This allows
> improved memory management capabilities in non-secure environments. With
> Agilex5 lifting this restriction, we are now extending the device tree
> bindings to support IOMMU for the Agilex5 SVC.
>
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@xxxxxxxxxx>
> Reviewed-by: Adrian Ng Ho Yin <adrianhoyin.ng@xxxxxxxxxx>
> Reviewed-by: Niravkumar L Rabara <niravkumarlaxmidas.rabara@xxxxxxxxxx>
Two reviews but...
>
> -required:
> - - compatible
> - - method
> - - memory-region
> +allOf:
> + - required:
> + - compatible
> + - method
> + - memory-region
... none told you this is not the correct syntax / style?
Were these reviews really happening? What exactly was reviewed here?
Best regards,
Krzysztof