RE: [PATCH v3] EDAC/ie31200: Fix error handling in ie31200_register_mci

[Zhuo, Qiuxu]

> From: Ma Ke <make24@xxxxxxxxxxx>
> Sent: Thursday, November 6, 2025 4:48 PM
> To: jbaron@xxxxxxxxxx; bp@xxxxxxxxx; Luck, Tony <tony.luck@xxxxxxxxx>;
> Zhuo, Qiuxu <qiuxu.zhuo@xxxxxxxxx>
> Cc: linux-edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; akpm@linux-
> foundation.org; Ma Ke <make24@xxxxxxxxxxx>
> Subject: [PATCH v3] EDAC/ie31200: Fix error handling in ie31200_register_mci
> 
> ie31200_register_mci() calls device_initialize() for priv->dev unconditionally.
> However, in the error path, put_device() is not called, leading to an
> imbalance. Similarly, in the unload path,
> put_device() is missing.
> 
> Although edac_mc_free() eventually frees the memory, it does not release the
> device initialized by device_initialize(). For code readability and proper pairing
> of device_initialize()/put_device(), add put_device() calls in both error and
> unload paths.
> 
> Found by code review.
> 
> Signed-off-by: Ma Ke <make24@xxxxxxxxxxx>
> ---
> Changes in v3:
> - moved put_device() from fail_free to fail_unmap to avoid using uninitialized
> priv variable when window allocation fails.

Oops ... I didn't catch that during v2 review. 

For v3:
Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>

> [...]