Re: [PATCH RESEND 1/3] dt-bindings: PCI: amlogic: Fix the register name of the DBI region

[Neil Armstrong]

On 11/8/25 11:40, Manivannan Sadhasivam wrote:
> On Thu, Nov 06, 2025 at 02:37:17PM +0530, Manivannan Sadhasivam wrote:
> > On Thu, Nov 06, 2025 at 09:30:15AM +0100, Krzysztof Kozlowski wrote:
> > > On Mon, Nov 03, 2025 at 03:42:58PM +0530, Manivannan Sadhasivam wrote:
> > > > On Mon, Nov 03, 2025 at 10:47:36AM +0100, Neil Armstrong wrote:
> > > > > Hi Mani,
> > > > >
> > > > > On 11/1/25 05:29, Manivannan Sadhasivam wrote:
> > > > > > Binding incorrectly specifies the 'DBI' region as 'ELBI'. DBI is a must
> > > > > > have region for DWC controllers as it has the Root Port and controller
> > > > > > specific registers, while ELBI has optional registers.
> > > > > >
> > > > > > Hence, fix the binding. Though this is an ABI break, this change is needed
> > > > > > to accurately describe the PCI memory map.
> > > > >
> > > > > Not fan of this ABI break, the current bindings should be marked as deprecated instead.
> > > >
> > > > Fair enough. Will make it as deprecated.
> > >
> > > The true question is what value was being passed as that item (ELBI)?
> > > Because if this was always DBI - device has DBI there - then what
> > > deprecation would change?
> >
> > Nothing, except not breaking old DTs with the binding check. That's why I
> > decided to remove it in the first place.
>
> Neil, do you still insist on marking the 'elbi' region deprecated than removing
> it?

Not really. if the original definition was wrong, let's fix it.

Neil

> - Mani