Re: [PATCH] tee: fix uninitialized pointers with free attr

[ally heev]

On Mon, 2025-11-10 at 09:57 +0100, Jens Wiklander wrote:
[..]
> > diff --git a/drivers/tee/qcomtee/call.c b/drivers/tee/qcomtee/call.c
> > index ac134452cc9cfd384c28d41547545f2c5748d86c..8b7b4decddd8d1811dc0a7cc46a4a4fbada45526 100644
> > --- a/drivers/tee/qcomtee/call.c
> > +++ b/drivers/tee/qcomtee/call.c
> > @@ -645,12 +645,13 @@ static void qcomtee_get_version(struct tee_device *teedev,
> >  static void qcomtee_get_qtee_feature_list(struct tee_context *ctx, u32 id,
> >                                           u32 *version)
> >  {
> > -       struct qcomtee_object_invoke_ctx *oic __free(kfree);
> >         struct qcomtee_object *client_env, *service;
> >         struct qcomtee_arg u[3] = { 0 };
> >         int result;
> > 
> > -       oic = qcomtee_object_invoke_ctx_alloc(ctx);
> > +       struct qcomtee_object_invoke_ctx *oic __free(kfree) =
> > +               qcomtee_object_invoke_ctx_alloc(ctx);
> 
> Can we zero-initialize oic at its original location instead? Doing it
> here looks messy.
> 
> Thanks,
> Jens
> 
> > +
> >         if (!oic)
> >                 return;
> > 
> > 
> > ---
> > base-commit: c9cfc122f03711a5124b4aafab3211cf4d35a2ac
> > change-id: 20251105-aheev-uninitialized-free-attr-tee-0221e45ec5a2
> > 
> > Best regards,
> > --
> > Ally Heev <allyheev@xxxxxxxxx>
> > 

Thanks, will fix it

Regards,
ALly