Re: [PATCH] lockdep: Add header and footer to surround warning reports

From: Geert Uytterhoeven

Date: Sat Nov 15 2025 - 11:36:56 EST


Hi Tzung-Bi,

On Fri, 14 Nov 2025 at 07:35, Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:
> Add header and footer to improve log parsing and automated analysis.
> This makes lockdep output easier to interpret.
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>

Thanks for your patch!

> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -1958,6 +1964,7 @@ print_circular_bug_header(struct lock_list *entry, unsigned int depth,
> return;
>
> pr_warn("\n");
> + pr_warn(CUT_HERE);
> pr_warn("======================================================\n");

I guess you can drop all lines printing a separator made of equal signs,
as CUT_HERE already contains a graphical separator.

> pr_warn("WARNING: possible circular locking dependency detected\n");
> print_kernel_ident();

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds