Re: [PATCH 2/3] drm/virtio: honor blob_alignment requirements

[Dmitry Osipenko]

On 11/10/25 15:52, Sergio Lopez wrote:
> diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
> index 8181b22b9b46..d558ba2d213a 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_vq.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
> @@ -1393,6 +1393,10 @@ int virtio_gpu_cmd_map(struct virtio_gpu_device *vgdev,
>  	struct virtio_gpu_vbuffer *vbuf;
>  	struct virtio_gpu_resp_map_info *resp_buf;
>  
> +	if (vgdev->has_blob_alignment &&
> +	    !IS_ALIGNED(offset, vgdev->blob_alignment))
> +		return -EINVAL;

The vram offset should have been validated when obj is created. Checking
offset here on cmd_map() should be unnecessary.

-- 
Best regards,
Dmitry