Re: [PATCH net-next v2 2/3] net: stmmac: Add glue driver for Motorcomm YT6801 ethernet controller
From: Russell King (Oracle)
Date: Tue Nov 11 2025 - 07:33:17 EST
On Tue, Nov 11, 2025 at 10:52:51AM +0000, Yao Zi wrote:
> + plat->bus_id = pci_dev_id(pdev);
> + plat->phy_addr = -1;
> + plat->phy_interface = PHY_INTERFACE_MODE_GMII;
> + plat->clk_csr = STMMAC_CSR_20_35M;
Could you include a comment indicating what the stmmac clock rate
actually is (the rate which is used to derive this divider) ? As
this is PCI, I'm guessing it's 33MHz, which fits with your divider
value.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!