RE: [PATCH v2 05/21] drm/amdgpu: Switch to use %ptSp

[Deucher, Alexander]

[Public]

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: Tuesday, November 11, 2025 7:20 AM
> To: Corey Minyard <corey@xxxxxxxxxxx>; Koenig, Christian
> <Christian.Koenig@xxxxxxx>; Dr. David Alan Gilbert <linux@xxxxxxxxxxx>;
> Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Thomas Zimmermann
> <tzimmermann@xxxxxxx>; Dmitry Baryshkov
> <dmitry.baryshkov@xxxxxxxxxxxxxxxx>; Rob Clark
> <robin.clark@xxxxxxxxxxxxxxxx>; Matthew Brost
> <matthew.brost@xxxxxxxxx>; Ulf Hansson <ulf.hansson@xxxxxxxxxx>; Andy
> Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>; Vitaly Lifshits
> <vitaly.lifshits@xxxxxxxxx>; Manivannan Sadhasivam <mani@xxxxxxxxxx>;
> Niklas Cassel <cassel@xxxxxxxxxx>; Calvin Owens <calvin@xxxxxxxxxx>; Vadim
> Fedorenko <vadim.fedorenko@xxxxxxxxx>; Sagi Maimon
> <maimon.sagi@xxxxxxxxx>; Martin K. Petersen
> <martin.petersen@xxxxxxxxxx>; Karan Tilak Kumar <kartilak@xxxxxxxxx>;
> Hans Verkuil <hverkuil+cisco@xxxxxxxxxx>; Casey Schaufler <casey@schaufler-
> ca.com>; Steven Rostedt <rostedt@xxxxxxxxxxx>; Petr Mladek
> <pmladek@xxxxxxxx>; Viacheslav Dubeyko <Slava.Dubeyko@xxxxxxx>; Max
> Kellermann <max.kellermann@xxxxxxxxx>; linux-doc@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; openipmi-developer@xxxxxxxxxxxxxxxxxxxxx; linux-
> media@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linaro-mm-
> sig@xxxxxxxxxxxxxxxx; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; linux-arm-
> msm@xxxxxxxxxxxxxxx; freedreno@xxxxxxxxxxxxxxxxxxxxx; intel-
> xe@xxxxxxxxxxxxxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx; linux-
> pci@xxxxxxxxxxxxxxx; linux-s390@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx;
> linux-staging@xxxxxxxxxxxxxxx; ceph-devel@xxxxxxxxxxxxxxx; linux-trace-
> kernel@xxxxxxxxxxxxxxx
> Cc: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>; Sergey Senozhatsky
> <senozhatsky@xxxxxxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>; Sumit
> Semwal <sumit.semwal@xxxxxxxxxx>; Gustavo Padovan
> <gustavo@xxxxxxxxxxx>; David Airlie <airlied@xxxxxxxxx>; Simona Vetter
> <simona@xxxxxxxx>; Maarten Lankhorst
> <maarten.lankhorst@xxxxxxxxxxxxxxx>; Maxime Ripard <mripard@xxxxxxxxxx>;
> Dmitry Baryshkov <lumag@xxxxxxxxxx>; Abhinav Kumar
> <abhinav.kumar@xxxxxxxxx>; Jessica Zhang <jesszhan0024@xxxxxxxxx>; Sean
> Paul <sean@xxxxxxxxxx>; Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>;
> Konrad Dybcio <konradybcio@xxxxxxxxxx>; Lucas De Marchi
> <lucas.demarchi@xxxxxxxxx>; Thomas Hellström
> <thomas.hellstrom@xxxxxxxxxxxxxxx>; Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>;
> Vladimir Oltean <olteanv@xxxxxxxxx>; Andrew Lunn <andrew@xxxxxxx>;
> David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni
> <pabeni@xxxxxxxxxx>; Tony Nguyen <anthony.l.nguyen@xxxxxxxxx>;
> Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>; Krzysztof Wilczyński
> <kwilczynski@xxxxxxxxxx>; Kishon Vijay Abraham I <kishon@xxxxxxxxxx>;
> Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; Rodolfo Giometti
> <giometti@xxxxxxxxxxxx>; Richard Cochran <richardcochran@xxxxxxxxx>;
> Jonathan Lemon <jonathan.lemon@xxxxxxxxx>; Stefan Haberland
> <sth@xxxxxxxxxxxxx>; Jan Hoeppner <hoeppner@xxxxxxxxxxxxx>; Heiko
> Carstens <hca@xxxxxxxxxxxxx>; Vasily Gorbik <gor@xxxxxxxxxxxxx>;
> Alexander Gordeev <agordeev@xxxxxxxxxxxxx>; Christian Borntraeger
> <borntraeger@xxxxxxxxxxxxx>; Sven Schnelle <svens@xxxxxxxxxxxxx>; Satish
> Kharat <satishkh@xxxxxxxxx>; Sesidhar Baddela <sebaddel@xxxxxxxxx>;
> James E.J. Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>; Mauro
> Carvalho Chehab <mchehab@xxxxxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>; Xiubo Li <xiubli@xxxxxxxxxx>; Ilya Dryomov
> <idryomov@xxxxxxxxx>; Masami Hiramatsu <mhiramat@xxxxxxxxxx>;
> Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>; Andrew Morton
> <akpm@xxxxxxxxxxxxxxxxxxxx>
> Subject: [PATCH v2 05/21] drm/amdgpu: Switch to use %ptSp
>
> Use %ptSp instead of open coded variants to print content of struct
> timespec64 in human readable format.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
> index 8a026bc9ea44..4e2fe6674db8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
> @@ -217,8 +217,7 @@ amdgpu_devcoredump_read(char *buffer, loff_t
> offset, size_t count,
>       drm_printf(&p, "version: " AMDGPU_COREDUMP_VERSION "\n");
>       drm_printf(&p, "kernel: " UTS_RELEASE "\n");
>       drm_printf(&p, "module: " KBUILD_MODNAME "\n");
> -     drm_printf(&p, "time: %lld.%09ld\n", coredump->reset_time.tv_sec,
> -                coredump->reset_time.tv_nsec);
> +     drm_printf(&p, "time: %ptSp\n", &coredump->reset_time);
>
>       if (coredump->reset_task_info.task.pid)
>               drm_printf(&p, "process_name: %s PID: %d\n",
> --
> 2.50.1