Re: [PATCH v6 4/6] pwm: tiehrpwm: implement .get_state callback

[Uwe Kleine-König]

Hello Rafael,

On Tue, Nov 25, 2025 at 12:48:30AM -0300, Rafael V. Volkmer wrote:
> From my reading of the PWM core, it seems acceptable for a driver to
> provide both the legacy apply/get_state callbacks and the waveform
> callbacks, with the logic factored so that they share
> the same hardware decoding.

No, that makes no sense. The waveform callbacks can do (nearly)
everything that the legacy calls can, so the idea to keep both types
strikes me.

> If you’d strongly prefer that tiehrpwm is
> converted directly to waveform without an intermediate get_state()
> series, I can rework the patches in that direction instead.

I don't prefer it strongly, I just wonder how sensible this is regarding
your (and a bit my) work force.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature