Re: [PATCH 06/11] mempool: factor out a mempool_alloc_from_pool helper

[Vlastimil Babka]

On 11/24/25 00:04, Hugh Dickins wrote:
> 
> You are completely right: it was me who was missing that the second
> pool->alloc is with the full gfp, so not an identical repeat of the
> the first; and so it is correct not to wait after the first attempt,
> so you are right to call with gfp_temp instead of gfp_mask there.
> 
> (And this also addresses my slight concern, of whether it was
> appropriate to be doing a pool->alloc after waiting for a mempool
> free: your way, there is no such wait, at least not that most
> important first->second time: the wait would instead be inside
> the pool->alloc probably, reclaiming.)
> 
> Yes, your fixup is better in all ways than mine, please go ahead.
> 
> Thanks,
> Hugh

Thanks, Hugh!