RE: [PATCH rtw-next v3] realtek/rtlwifi: remove unused two if blocks and put unicast set inner if and else block

[Ping-Ke Shih]

Les Boys <lesboyspp43@xxxxxxxxxxx> wrote:


Not sure why you remove entire commit message?

> 
> ---
> CHANGE:
> 1. Ensure used the origin as base
> 2. Format fixings

Still wrong place. 

There are many examples in public. One of them is [1] I sent before.

[1] https://lore.kernel.org/linux-wireless/910a0ce4bf9c47d89f0da8399ef3927e@xxxxxxxxxxx/T/#md11d111fbdaaa8b37787c7f2197d41b500456f38

> 
> Signed-off-by: Les Boys <lesboyspp43@xxxxxxxxxxx>
> ---
>  drivers/net/wireless/realtek/rtlwifi/pci.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c b/drivers/net/wireless/realtek/rtlwifi/pci.c
> index d08046926..a07de6b57 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/pci.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c
> @@ -752,14 +752,13 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)

I meant you need changes like this.

- bool unicast = false;
+ bool unicast;

>                         memcpy(IEEE80211_SKB_RXCB(skb), &rx_status,
>                                sizeof(rx_status));
> 
> -                       if (is_broadcast_ether_addr(hdr->addr1)) {
> -                               ;/*TODO*/
> -                       } else if (is_multicast_ether_addr(hdr->addr1)) {
> -                               ;/*TODO*/
> -                       } else {
> +                       if (is_unicast_ether_addr(hdr->addr1)) {
>                                 unicast = true;
>                                 rtlpriv->stats.rxbytesunicast += skb->len;
> +                       } else {
> +                               unicast = false;
>                         }
> +
>                         rtl_is_special_data(hw, skb, false, true);
> 
>                         if (ieee80211_is_data(fc)) {
> --
> 2.44.0