RE: [PATCH net v2] platform/x86: intel_pmc_ipc: fix ACPI buffer memory leak

[Ilpo Järvinen]

On Tue, 25 Nov 2025, Liu, Yongxin wrote:

> > -----Original Message-----
> > From: Jakub Kicinski <kuba@xxxxxxxxxx>
> > Sent: Tuesday, November 25, 2025 11:15
> > To: Liu, Yongxin <Yongxin.Liu@xxxxxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> > david.e.box@xxxxxxxxxxxxxxx; ilpo.jarvinen@xxxxxxxxxxxxxxx; andrew@xxxxxxx;
> > platform-driver-x86@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH net v2] platform/x86: intel_pmc_ipc: fix ACPI buffer
> > memory leak
> > 
> > CAUTION: This email comes from a non Wind River email account!
> > Do not click links or open attachments unless you recognize the sender and
> > know the content is safe.
> > 
> > On Tue, 25 Nov 2025 03:07:30 +0000 Liu, Yongxin wrote:
> > > > -----Original Message-----
> > > > From: Jakub Kicinski <kuba@xxxxxxxxxx>
> > > > Sent: Tuesday, November 25, 2025 10:56
> > > > To: Liu, Yongxin <Yongxin.Liu@xxxxxxxxxxxxx>
> > > > Cc: linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> > > > david.e.box@xxxxxxxxxxxxxxx; ilpo.jarvinen@xxxxxxxxxxxxxxx;
> > > > andrew@xxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx;
> > > > stable@xxxxxxxxxxxxxxx
> > > > Subject: Re: [PATCH net v2] platform/x86: intel_pmc_ipc: fix ACPI
> > > > buffer memory leak
> > > >
> > > > CAUTION: This email comes from a non Wind River email account!
> > > > Do not click links or open attachments unless you recognize the
> > > > sender and know the content is safe.
> > > >
> > > > On Tue, 25 Nov 2025 10:29:53 +0800 yongxin.liu@xxxxxxxxxxxxx wrote:
> > > > > Subject: [PATCH net v2] platform/x86: intel_pmc_ipc: fix ACPI
> > > > > buffer
> > > > memory leak
> > > >
> > > > Presumably typo in the subject? Why would this go via netdev/net.. ?
> > >
> > > Because the only caller of intel_pmc_ipc() is
> > drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c.
> > > I have sent both to the platform-driver-x86@xxxxxxxxxxxxxxx and
> > netdev@xxxxxxxxxxxxxxx mailing lists.
> > 
> > Just to be clear -- the CC is fine, but given the code path - the platform
> > maintainer will likely take this via their tree. And the subject
> > designation is to indicate which maintainer you're expecting to process
> > the patch.
> 
> Got it. If needed, I will resend with the correct subject.

Hi Yongxin,

As this code belongs to pdx86 domain, please ignore Andrew's feedback on 
not using __free() (which was given with the assumption this would fall 
under netdev's domain that applies a different rule).

Using cleanup.h helpers is required for new pdx86 code when it avoids 
error handling gotos.

-- 
 i.