Re: [tip: objtool/urgent] objtool: Consolidate annotation macros

From: Josh Poimboeuf

Date: Wed Dec 03 2025 - 12:51:44 EST


On Wed, Dec 03, 2025 at 09:44:45AM -0800, Linus Torvalds wrote:
> On Wed, 3 Dec 2025 at 09:21, Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > It *feels* like this should just all be
> >
> > 911: .pushsection .discard.annotate_insn ; .long 911b - .; .long 1; .popsection
> > jmp __x86_return_thunk
> >
> > instead.
>
> Actually, I think it should just be
>
> 911: jmp __x86_return_thunk
> .pushsection .discard.annotate_insn ; .long 911b - . , 1; .popsection
>
> but again: it's entirely possible that there's something I am missing.

Indeed, we can combine the longs (though see my other email for the
explanation about the mergeable thing).

--
Josh