Re: [PATCH v15 07/32] x86,fs/resctrl: Use struct rdt_domain_hdr when reading counters

From: Reinette Chatre
Date: Tue Dec 09 2025 - 14:38:40 EST


Hi Tony,

On 12/4/25 12:53 PM, Tony Luck wrote:
> Convert the whole call sequence from mon_event_read() to resctrl_arch_rmid_read()
> to pass resource independent struct rdt_domain_hdr instead of an L3 specific
> domain structure to prepare for monitoring events in other resources.

Please add a snippet to inform reader about the additional change that splits the
event counting flow. Here is a draft of the idea to start:

This additional layer of indirection obscures which aspects of event counting depend
on a valid domain. Event initialization, support for assignable counters, and normal
event counting implicitly depend on a valid domain while summing of domains does not.
Split summing domains from the core event counting handling to make their respective
dependencies obvious.

>
> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
> ---

| Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Reinette