Re: [PATCH v2 1/2] x86/tlb/trace: Export the TLB_REMOTE_WRONG_CPU enum

From: Lorenzo Stoakes

Date: Mon Dec 15 2025 - 07:39:58 EST


On Fri, Dec 12, 2025 at 04:08:07AM -0500, Tal Zussman wrote:
> When the TLB_REMOTE_WRONG_CPU enum was introduced for the tlb_flush
> tracepoint, the enum was not exported to userspace. Add it to the
> appropriate macro definition to enable parsing by userspace tools, as
> per [0].
>
> [0] Link: https://lore.kernel.org/all/20150403013802.220157513@xxxxxxxxxxx
>
> Fixes: 2815a56e4b72 ("x86/mm/tlb: Add tracepoint for TLB flush IPI to stale CPU")
> Reviewed-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
> Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
> Reviewed-by: Rik van Riel <riel@xxxxxxxxxxx>
> Signed-off-by: Tal Zussman <tz2294@xxxxxxxxxxxx>

LGTM, so:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>

> ---
> include/trace/events/tlb.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/trace/events/tlb.h b/include/trace/events/tlb.h
> index b4d8e7dc38f8..725a75720a23 100644
> --- a/include/trace/events/tlb.h
> +++ b/include/trace/events/tlb.h
> @@ -13,7 +13,8 @@
> EM( TLB_REMOTE_SHOOTDOWN, "remote shootdown" ) \
> EM( TLB_LOCAL_SHOOTDOWN, "local shootdown" ) \
> EM( TLB_LOCAL_MM_SHOOTDOWN, "local mm shootdown" ) \
> - EMe( TLB_REMOTE_SEND_IPI, "remote ipi send" )
> + EM( TLB_REMOTE_SEND_IPI, "remote ipi send" ) \
> + EMe( TLB_REMOTE_WRONG_CPU, "remote wrong CPU" )
>
> /*
> * First define the enums in TLB_FLUSH_REASON to be exported to userspace
>
> --
> 2.39.5
>