Re: [PATCH 1/1] scsi: ufs: core: Fix error handler encryption support

[Christoph Hellwig]

On Wed, Dec 10, 2025 at 09:44:52AM -0800, Bart Van Assche wrote:
> On 12/9/25 10:48 PM, Christoph Hellwig wrote:
> > As mentioned last round, why are you even calling into the crypto
> > code here?  Calling that for a request without a crypt context,
> > which includes all of them that do not transfer any data makes no
> > sense to start with.
> 
> ufshcd_prepare_lrbp_crypto() only has one caller. Moving the new test
> from inside ufshcd_prepare_lrbp_crypto() into its caller should be easy.

I don't think callers vs calle is the important part here.  It is to
check if any actual data is tranferred instead of special casing EH
commands.