Re: [PATCH RFC 01/16] dt-bindings: hwmon: Convert aspeed,ast2400-pwm-tacho to DT schema

From: Guenter Roeck

Date: Thu Dec 11 2025 - 15:27:51 EST


On 12/11/25 00:45, Andrew Jeffery wrote:
From: "Rob Herring (Arm)" <robh@xxxxxxxxxx>

Convert the ASpeed fan controller binding to DT schema format.

The '#cooling-cells' value used is 1 rather than 2. '#size-cells' is 0
rather 1.

Some users define more that 8 fan nodes where 2 fans share a PWM. The
driver seems to let the 2nd fan just overwrite the 1st one. That also
creates some addressing errors in the DT (duplicate addresses and wrong
unit-addresses).

Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
Signed-off-by: Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx>

I am not sure I understand what the plan is here. I am assuming it will be
applied through a non-hwmon branch.

Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>