Re: [PATCH v3] arm64: dts: qcom: monaco: add QCrypto node

[Krzysztof Kozlowski]

On 24/12/2025 09:42, Krzysztof Kozlowski wrote:
> On 24/12/2025 09:33, Abhinaba Rakshit wrote:
>> Add Qualcomm Crypto Engine device node for Monaco platform.
>>
>> QCE and Crypto DMA nodes patch was applied as part of
>> commit a86d84409947 ("arm64: dts: qcom: qcs8300: add QCrypto nodes"),
>> however was partially reverted by commit cdc117c40537 ("arm64: dts: qcom:
>> qcs8300: Partially revert "arm64: dts: qcom: qcs8300: add QCrypto nodes"")
>> due to compatible string being mismatched against schema.
> 
> ...due to Qualcomm engineer not ever bothering to build test the code.
> 
> Was it build tested now? Typically this is implied by trusting people,
> but not here. Trust is lost.

And to be clear - I found more QCrypto DTS patches which were never
build tested and never tested on the hardware. This was not a single
case, but a pattern.

Best regards,
Krzysztof