Re: [PATCH 1/2] [PATCH v1 1/2] dt-bindings: arm: qcom: add Acer Swift SFA14-11

[Krzysztof Kozlowski]

On Sun, Jan 04, 2026 at 10:36:44PM +0800, weifu wu wrote:
> Add DT binding documentation for Acer Swift SFA14-11 laptop based on
> Qualcomm X1E78100 SoC.
> 
> Signed-off-by: weifu wu <boss@xxxxxxxx>

Your posting is incomplete. Only 1/2 reached mailing list and people.

> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 4eb0a7a9ee4a..55d4afa9a70e 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1065,6 +1065,13 @@ properties:
>            - const: qcom,x1e001de
>            - const: qcom,x1e80100
>  
> +      - items:
> +          - enum:
> +              - acer,swift-sfa14-11
> +          - const: acer,swift-sfa14-11

This makes no sense - device is not compatible with its own. Just add it
to existing entry for all x1e78100 laptops.

Best regards,
Krzysztof