Re: [PATCH] cxl/pci: Remove outdated FIXME comment and BUILD_BUG_ON

[Jonathan Cameron]

On Tue, 6 Jan 2026 10:55:13 -0700
Dave Jiang <dave.jiang@xxxxxxxxx> wrote:

> On 1/5/26 1:38 PM, Samasth Norway Ananda wrote:
> > Remove the outdated FIXME comment about switching to struct_group() and
> > the associated BUILD_BUG_ON check. This work was already completed in
> > commit 301e68dd9b9b ("cxl/core: Replace unions with struct_group()")
> > which converted struct cxl_regs to use struct_group_tagged().
> > 
> > The BUILD_BUG_ON was checking that anonymous union layout was preserved,
> > but since struct_group() now handles this correctly, the compile-time
> > check is no longer necessary.
> > 
> > Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@xxxxxxxxxx>  
> 
> Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>
Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>