Re: [PATCH v2 1/2] dt-bindings: touchscreen: trivial-touch: Drop 'interrupts' requirement for old Ilitek
From: Frank Li
Date: Thu Jan 15 2026 - 10:25:41 EST
On Thu, Jan 15, 2026 at 03:34:58AM +0100, Marek Vasut wrote:
> The old Ilitek touch controllers V3 and V6 can operate without
> interrupt line, in polling mode. Drop the 'interrupts' property
> requirement for those four controllers. To avoid overloading the
> trivial-touch, fork the old Ilitek V3/V6 touch controller binding
> into separate document.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> ---
Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> Cc: Conor Dooley <conor+dt@xxxxxxxxxx>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Cc: Frank Li <Frank.Li@xxxxxxx>
> Cc: Job Noorman <job@xxxxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-input@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
> ---
> V2: Fork the Ilitek V3/V6 bindings into separate document
> ---
> .../input/touchscreen/ilitek,ili210x.yaml | 51 +++++++++++++++++++
> .../input/touchscreen/trivial-touch.yaml | 4 --
> 2 files changed, 51 insertions(+), 4 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/ilitek,ili210x.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ilitek,ili210x.yaml b/Documentation/devicetree/bindings/input/touchscreen/ilitek,ili210x.yaml
> new file mode 100644
> index 0000000000000..1d02aaba64f97
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/ilitek,ili210x.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/ilitek,ili210x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ilitek ILI21xx/ILI251x V3/V6 touch screen controller with i2c interface
> +
> +maintainers:
> + - Frank Li <Frank.Li@xxxxxxx>
> + - Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> +
> +properties:
> + compatible:
> + enum:
> + - ilitek,ili210x
> + - ilitek,ili2117
> + - ilitek,ili2120
> + - ilitek,ili251x
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + reset-gpios:
> + maxItems: 1
> +
> + wakeup-source: true
> +
> +allOf:
> + - $ref: touchscreen.yaml
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + touchscreen@41 {
> + compatible = "ilitek,ili2120";
> + reg = <0x41>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml b/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
> index fa27c6754ca4e..6441d21223caf 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
> @@ -23,9 +23,6 @@ properties:
> # Hynitron cstxxx series touchscreen controller
> - hynitron,cst340
> # Ilitek I2C Touchscreen Controller
> - - ilitek,ili210x
> - - ilitek,ili2117
> - - ilitek,ili2120
> - ilitek,ili2130
> - ilitek,ili2131
> - ilitek,ili2132
> @@ -33,7 +30,6 @@ properties:
> - ilitek,ili2322
> - ilitek,ili2323
> - ilitek,ili2326
> - - ilitek,ili251x
> - ilitek,ili2520
> - ilitek,ili2521
> # MAXI MAX11801 Resistive touch screen controller with i2c interface
> --
> 2.51.0
>