Re: [PATCH v5 13/15] PCI: qcom: Drop the assert_perst() callbacks

From: Bartosz Golaszewski

Date: Thu Jan 15 2026 - 09:29:04 EST


On Thu, 15 Jan 2026 08:29:05 +0100, Manivannan Sadhasivam via B4 Relay
<devnull+manivannan.sadhasivam.oss.qualcomm.com@xxxxxxxxxx> said:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>
>
> Previously, the pcie-qcom driver probed first, deasserted PERST#, enabled
> link training and scanned the bus. By the time the pwrctrl driver probe got
> called, link training was already enabled by the controller driver.
>
> Thus the pwrctrl drivers had to call the .assert_perst() callback, to
> assert PERST#, power on the needed resources, and then call the
> .assert_perst() callback to deassert PERST#.
>
> Now since all pwrctrl drivers and this controller driver have been
> converted to the new pwrctrl design where the pwrctrl drivers will first
> power on the devices before this driver deasserts PERST# and scan the bus.
> So there is no longer a need for .assert_perst() callback in this driver
> and in DWC core driver. Hence, drop them.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>