Re: [RFC PATCH v4 02/28] sched/deadline: Distinct between dl_rq and my_q

[Juri Lelli]

Hello,

Think we want s/Distinct/Distinguish/ in $SUBJECT.

On 01/12/25 13:41, Yuri Andriaccio wrote:
> From: luca abeni <luca.abeni@xxxxxxxxxxxxxxx>
> 
> Split the single runqueue pointer in sched_dl_entity into two separate
> pointers, following the existing pattern used by sched_rt_entity:
> 
> - dl_rq: Points to the deadline runqueue where this entity is queued
>          (global runqueue).
> - my_q:  Points to the runqueue that this entity serves (for servers).
> 
> This distinction is currently redundant for the fair_server (both point
> to the same CPU's structures), but is essential for future RT cgroup
> support where deadline servers will be queued on the global dl_rq while
> serving tasks from cgroup-specific runqueues.
> 
> Update rq_of_dl_se() to use container_of() to recover the global rq from
> dl_rq, and update fair.c to explicitly use my_q (local rq) when accessing
> the served runqueue.
> 
> Update dl_server_init() to take a dl_rq pointer (use to retrieve the
> global runqueue where the dl_server is scheduled) and a rq pointer (for
> the local runqueue served by the server).
> 
> Signed-off-by: luca abeni <luca.abeni@xxxxxxxxxxxxxxx>
> Signed-off-by: Yuri Andriaccio <yurand2000@xxxxxxxxx>

Reviewed-by: Juri Lelli <juri.lelli@xxxxxxxxxx>

Thanks,
Juri