Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

[neil . armstrong]

On 1/14/26 11:07, Nick Xie wrote:
> Krzysztof Kozlowski <krzk@xxxxxxxxxx> 于2026年1月14日周三 16:51写道：
> > On Wed, Jan 14, 2026 at 02:25:48PM +0800, Nick Xie wrote:
> > > Add devicetree binding for Khadas VIM1S board based on
> > > Amlogic S4 S905Y4 SoC.
> > >
> > > Signed-off-by: Nick Xie <nick@xxxxxxxxxx>
> >
> > You still have the same From/SoB mismatch.
>
> OK,  I will fix it in next version.
>
> > > ---
> > >   Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
> > >   1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> > > index 08d9963fe9259..55663e0f7f915 100644
> > > --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> > > @@ -247,6 +247,12 @@ properties:
> > >                 - amlogic,aq222
> > >             - const: amlogic,s4
> > >
> > > +      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
> > > +        items:
> > > +          - enum:
> >
> > Yopu already have exactly such enum with such description, so your
> > compatible goes there. Look - it is called "Boards" - plural.
>
> The exist board aq222 is based on SoC S905X2, but the new board vim1s
> is baed on S905Y4,
> they are different SoC, so we need to put S905Y4 under S805X2 ?

It depends, if the S805X2 and the S905Y4 are not compatible (different dies)
and not the same die in 2 different but compatible packages, then a secondary
compatible should be added like we did for amlogic,g12b or amlogic,meson-gxl.

Neil

> > > +              - khadas,vim1s
> > > +          - const: amlogic,s4
> >
> > Best regards,
> > Krzysztof