Re: [PATCH 25/27] phy: ti: phy-j721e-wiz: convert from divider_round_rate() to divider_determine_rate()

From: Vinod Koul

Date: Wed Jan 21 2026 - 02:57:19 EST


On 15-01-26, 09:18, Brian Masney wrote:
> Hi Vinod,
>
> On Wed, Jan 14, 2026 at 07:47:18PM +0530, Vinod Koul wrote:
> > On 08-01-26, 16:16, Brian Masney wrote:
> > > The divider_round_rate() function is now deprecated, so let's migrate
> > > to divider_determine_rate() instead so that this deprecated API can be
> > > removed.
> > >
> > > Note that when the main function itself was migrated to use
> > > determine_rate, this was mistakenly converted to:
> > >
> > > req->rate = divider_round_rate(...)
> > >
> > > This is invalid in the case when an error occurs since it can set the
> > > rate to a negative value.
> >
> > Acked-by: Vinod Koul <vkoul@xxxxxxxxxx>
>
> Thanks for the Acked-by.
>
> However, this patch depends on this other series of mine that's merged
> into your phy tree:

Should I pick this one then..? If there are no other dependencies...

>
> https://lore.kernel.org/linux-clk/176661322399.4169.14248756511703978007@lazor/
>
> Stephen asked for an Acked-by for that series or an immutable branch.
>
> This will allow us to remove round_rate from the clk core.
>
> I also have a small series to post that's dependent on all of this that
> lets us get rid of the noop determine_rate implementations that only
> 'return 0'. I haven't posted that because of the dependencies.
>
> Brian

--
~Vinod