Re: [PATCH 17/21] mfd: wm8350-core: Use IRQF_ONESHOT

[Sebastian Andrzej Siewior]

On 2026-01-23 16:52:59 [+0200], Andy Shevchenko wrote:
> On Fri, Jan 23, 2026 at 12:37:03PM +0100, Sebastian Andrzej Siewior wrote:
> > Using a threaded interrupt without a dedicated primary handler mandates
> > the IRQF_ONESHOT flag to mask the interrupt source while the threaded
> > handler is active. Otherwise the interrupt can fire again before the
> > threaded handler had a chance to run.
> > 
> > Mark explained that this should not happen with this hardware since it a
> 
> "it is a" ?

yes.

> > slow irqchip which is behind an I2C/ SPI bus but the IRQ-core will
> > refuse to accept such a handler.
> > 
> > Set IRQF_ONESHOT so the interrupt source is masked until the secondary
> > handler is done.
> 
> ...
> 
> > Cc: Lee Jones <lee@xxxxxxxxxx>
> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Cc: patches@xxxxxxxxxxxxxxxxxxxxx
> > Cc: Mark Brown <broonie@xxxxxxxxxx>
> 
> Cc list can be moved out from the commit message.

If I move it out, the list won't be CCed.

Sebastian